fix: render base variables into templates instead of tfvars (DEVEX-287) - #26436
Merged
Merged
Conversation
jeremyruppel
changed the base branch from
jeremy/devex-287-fe-templatecustomizationsstep
to
graphite-base/26436
June 16, 2026 21:31
jeremyruppel
force-pushed
the
graphite-base/26436
branch
from
June 16, 2026 21:31
1adc078 to
9ec0473
Compare
jeremyruppel
changed the base branch from
graphite-base/26436
to
jeremy/devex-287-be-template-builder-fixes
June 16, 2026 21:31
This was referenced Jun 16, 2026
Contributor
Author
jeremyruppel
changed the base branch from
jeremy/devex-287-be-template-builder-fixes
to
jeremy/devex-287-fe-templatecustomizationsstep
June 16, 2026 21:32
jeremyruppel
changed the base branch from
jeremy/devex-287-fe-templatecustomizationsstep
to
graphite-base/26436
June 16, 2026 21:32
jeremyruppel
force-pushed
the
graphite-base/26436
branch
from
June 16, 2026 21:32
1adc078 to
9ec0473
Compare
jeremyruppel
changed the base branch from
graphite-base/26436
to
jeremy/devex-287-be-template-builder-fixes
June 16, 2026 21:32
jeremyruppel
changed the base branch from
jeremy/devex-287-be-template-builder-fixes
to
jeremy/devex-287-fe-templatecustomizationsstep
June 16, 2026 21:33
jeremyruppel
changed the base branch from
jeremy/devex-287-fe-templatecustomizationsstep
to
graphite-base/26436
June 16, 2026 21:33
jeremyruppel
force-pushed
the
graphite-base/26436
branch
from
June 16, 2026 21:33
1adc078 to
9ec0473
Compare
jeremyruppel
changed the base branch from
graphite-base/26436
to
jeremy/devex-287-be-template-builder-fixes
June 16, 2026 21:33
jeremyruppel
force-pushed
the
jeremy/devex-287-be-base-variable-rendering
branch
from
June 16, 2026 21:35
cc6db20 to
d5d8096
Compare
jeremyruppel
force-pushed
the
jeremy/devex-287-be-template-builder-fixes
branch
from
June 17, 2026 15:59
9ec0473 to
df0f468
Compare
jeremyruppel
force-pushed
the
jeremy/devex-287-be-base-variable-rendering
branch
from
June 17, 2026 15:59
d5d8096 to
94c6e2c
Compare
jeremyruppel
marked this pull request as ready for review
June 17, 2026 16:36
jeremyruppel
force-pushed
the
jeremy/devex-287-be-template-builder-fixes
branch
from
June 17, 2026 18:58
df0f468 to
e41a23d
Compare
jeremyruppel
force-pushed
the
jeremy/devex-287-be-base-variable-rendering
branch
2 times, most recently
from
June 18, 2026 13:43
77ae6b6 to
e0a04c0
Compare
jeremyruppel
force-pushed
the
jeremy/devex-287-be-template-builder-fixes
branch
from
June 18, 2026 13:43
e41a23d to
6589566
Compare
jeremyruppel
changed the base branch from
jeremy/devex-287-be-template-builder-fixes
to
graphite-base/26436
June 18, 2026 13:52
jeremyruppel
changed the base branch from
graphite-base/26436
to
jeremy/devex-287-fe-templatecustomizationsstep
June 18, 2026 13:52
This was referenced Jun 18, 2026
zenithwolf1000
approved these changes
Jun 22, 2026
jeremyruppel
force-pushed
the
jeremy/devex-287-fe-templatecustomizationsstep
branch
2 times, most recently
from
June 23, 2026 14:03
68b1a19 to
5fbde20
Compare
Base automatically changed from
jeremy/devex-287-fe-templatecustomizationsstep
to
main
June 23, 2026 14:23
…tead of tfvars
The kubernetes base template used Terraform variable blocks and var.*
references for use_kubeconfig and namespace, but the composed tar bundle
never included a .tfvars file, so terraform plan failed with 'required
template variables need values'.
Fix: base templates now use Go template variables ({{ .Variables.* }})
like module templates do. renderBase() validates and HCL-quotes base
variable values via mergeBaseVariables(). DefaultBaseRenderContext()
populates default variable values from the manifest.
Also adds explicit 'variable is required' validation to both
mergeBaseVariables and mergeModuleVariables, replacing the previous
reliance on missingkey=error at render time.
jeremyruppel
force-pushed
the
jeremy/devex-287-be-base-variable-rendering
branch
from
June 23, 2026 14:36
e0a04c0 to
342778b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Template Builder wizard PR stack.
Problem
The kubernetes base template used Terraform
variableblocks andvar.*references foruse_kubeconfigandnamespace, but the composed tar bundle never included a.tfvarsfile. This causedterraform planto fail with "required template variables need values: namespace".Fix
Base templates now use Go template variables (
{{ .Variables.* }}) just like module templates do. Values are validated, HCL-quoted, and rendered directly into the output HCL.Also adds explicit "variable is required" validation to both
mergeBaseVariablesandmergeModuleVariables, replacing the previous reliance onmissingkey=errorat render time for clearer error messages.Note
Generated by Coder Agents on behalf of @jeremyruppel