feat: add BaseTemplateParametersStep - #26426
Merged
jeremyruppel merged 3 commits intoJun 17, 2026
Merged
Conversation
This was referenced Jun 16, 2026
Contributor
Author
This was referenced Jun 16, 2026
jeremyruppel
commented
Jun 16, 2026
|
|
||
| function detailsUrl(baseId: string): string { | ||
| return `https://registry.coder.com/templates/${baseId}`; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
this will come from the backend in a future PR
jeremyruppel
marked this pull request as ready for review
June 16, 2026 17:51
jeremyruppel
requested review from
aqandrew,
aslilac,
code-asher and
zenithwolf1000
June 16, 2026 18:00
This was referenced Jun 16, 2026
jeremyruppel
force-pushed
the
jeremy/devex-284-fe-basetemplateparametersstep
branch
from
June 16, 2026 20:42
27cd694 to
94f5fb5
Compare
jeremyruppel
force-pushed
the
jeremy/devex-284-be-base-template-variables
branch
from
June 16, 2026 20:42
d34528f to
7fa30b7
Compare
Add support for base template variables in the template builder: - Add Variables field to BaseManifest, reusing ModuleVariable - Add variables to kubernetes base.json (use_kubeconfig, namespace) - Add Variables to codersdk.TemplateBuilderBase - Add BaseVariableValues to compose and create-template requests - Thread base variable values through the compose pipeline into BaseRenderContext - Add baseVariablesToSDK helper in handler to convert and filter computed variables - Restructure TestTemplateBuilderBases/OK as table-driven specs with per-base variable assertions - Regenerate TypeScript types and API docs
Implement the base template parameters wizard step: - Add BaseTemplateParametersStep component that renders a form for base template variables (text inputs for string/number, switches for bool), reading variable definitions from the cached bases query - Wire the step into TemplateBuilderPageView for the base-parameters step ID - Update BaseInfraSelectStep to set hasParameters from the base's variables, enabling the skip logic in the step registry - Update toComposeRequest to include base_variable_values when set - Add test for base_variable_values in compose request projection
jeremyruppel
force-pushed
the
jeremy/devex-284-be-base-template-variables
branch
from
June 17, 2026 15:59
7fa30b7 to
c805e35
Compare
jeremyruppel
force-pushed
the
jeremy/devex-284-fe-basetemplateparametersstep
branch
from
June 17, 2026 15:59
94f5fb5 to
25ac414
Compare
Base automatically changed from
jeremy/devex-284-be-base-template-variables
to
main
June 17, 2026 16:22
jeremyruppel
changed the title
zenithwolf1000
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the base template parameters wizard step, which renders a configuration form for base template variables using the existing
TemplateConfigurationandConfigurationFieldcomponents.TemplateBuilderModuleVariabletoConfigurationFieldDefinition(switch for bool, text input for string/number)baseParametersCompletehelper)toComposeRequestto includebase_variable_valuesin the API payloadRelates to DEVEX-284.
Note
This PR was authored with Coder Agents.