feat(site/src/pages/TemplateBuilder): add ModuleSettingsStep - #26428
Merged
Conversation
This was referenced Jun 16, 2026
Contributor
Author
This was referenced Jun 16, 2026
jeremyruppel
commented
Jun 16, 2026
|
|
||
| function moduleDetailsUrl(moduleId: string): string { | ||
| return `https://registry.coder.com/modules/${moduleId}`; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
like the other PRs, this will come from the backend soon
jeremyruppel
marked this pull request as ready for review
June 16, 2026 17:54
jeremyruppel
requested review from
aqandrew,
aslilac,
code-asher and
zenithwolf1000
June 16, 2026 18:02
This was referenced Jun 16, 2026
jeremyruppel
force-pushed
the
jeremy/devex-285-fe-moduleselectstep
branch
from
June 16, 2026 20:42
32f0468 to
ec336be
Compare
jeremyruppel
force-pushed
the
jeremy/devex-286-fe-modulesettingsstep
branch
from
June 16, 2026 20:42
39f07dd to
bc5ca0b
Compare
jeremyruppel
force-pushed
the
jeremy/devex-285-fe-moduleselectstep
branch
from
June 17, 2026 15:59
ec336be to
612d943
Compare
jeremyruppel
force-pushed
the
jeremy/devex-286-fe-modulesettingsstep
branch
from
June 17, 2026 15:59
bc5ca0b to
6723495
Compare
jeremyruppel
force-pushed
the
jeremy/devex-285-fe-moduleselectstep
branch
from
June 17, 2026 18:58
612d943 to
0094680
Compare
jeremyruppel
force-pushed
the
jeremy/devex-286-fe-modulesettingsstep
branch
from
June 17, 2026 18:58
6723495 to
4c13d89
Compare
Implement the module settings wizard step: - Add ModuleSettingsStep component that renders a ModuleConfiguration card per selected module with configurable variable fields - Map non-sensitive variables to ConfigurationField definitions (switch for bool, text input for string/number) - Show info notice for sensitive variables indicating they will be collected from developers at workspace creation - Export moduleSettingsComplete helper to validate required fields - Extend canContinue in PageView to gate module-settings step - Wire the step into TemplateBuilderPageView with SET_MODULE_VARIABLES dispatch
jeremyruppel
force-pushed
the
jeremy/devex-286-fe-modulesettingsstep
branch
from
June 18, 2026 13:43
4c13d89 to
9d3600f
Compare
This was referenced Jun 18, 2026
aqandrew
approved these changes
Jun 18, 2026
aqandrew
left a comment
aqandrew
left a comment
Contributor
There was a problem hiding this comment.
Lgtm, just one non-blocking question about an edge case when deselecting modules. If there ends up being some complexity I didn't account for in my suggestion, I'm good with merging this PR as is and handling that edge case in a separate issue/PR
… sidebar Co-authored-by: Andrew Aquino <dawneraq@gmail.com>
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the module settings wizard step, which renders a
ModuleConfigurationcard per selected module with variable configuration fields.ConfigurationFieldDefinition(switch for bool, text input for string/number)codetags for sensitive variables that will be collected from developers at workspace creationmoduleSettingsCompletehelper)Relates to DEVEX-286.
Note
This PR was authored with Coder Agents.